Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HWDEF : Squash of all Carbonix HWDEFs #174

Merged
merged 6 commits into from
Aug 29, 2024
Merged

HWDEF : Squash of all Carbonix HWDEFs #174

merged 6 commits into from
Aug 29, 2024

Conversation

Pradeep-Carbonix
Copy link
Contributor

@Pradeep-Carbonix Pradeep-Carbonix commented Aug 15, 2024 •
edited
Loading

@robertlong13 robertlong13 force-pushed the feature/SW-304-ci-squash-of-all-carbonix-hwdefs_V2 branch 3 times, most recently from 110f8f1 to ffafdba Compare August 15, 2024 03:32
@Pradeep-Carbonix Pradeep-Carbonix force-pushed the feature/SW-304-ci-squash-of-all-carbonix-hwdefs_V2 branch 2 times, most recently from b233538 to f426cd7 Compare August 15, 2024 04:39
@Pradeep-Carbonix Pradeep-Carbonix force-pushed the feature/SW-304-ci-squash-of-all-carbonix-hwdefs_V2 branch from f426cd7 to 1862b0f Compare August 26, 2024 04:21
@Pradeep-Carbonix
Tools : include missing cx bootloader files
315a310 
 - CarbonixF405-no-crystal_bl.bin
 - CarbonixF405-no-crystal_bl.hex
 - CarbonixF405_bl.hex
 - CarbonixL496_bl.hex (If required)
@Pradeep-Carbonix
HWDEF : Squash of all Carbonix HWDEFs
7b2b400
@Pradeep-Carbonix
HWDEF : remove unused variables in lua
9f3658b
@Pradeep-Carbonix Pradeep-Carbonix force-pushed the feature/SW-304-ci-squash-of-all-carbonix-hwdefs_V2 branch from 1b8e645 to 9f3658b Compare August 26, 2024 07:36
robertlong13
robertlong13 requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@robertlong13 robertlong13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but we should wrap two other things into this PR:

  1. Migration of params to 4.5
  2. Regeneration of features.inc

@Pradeep-Carbonix Pradeep-Carbonix force-pushed the feature/SW-304-ci-squash-of-all-carbonix-hwdefs_V2 branch from 72e2524 to c399e71 Compare August 28, 2024 04:13
@Pradeep-Carbonix
Copy link
Contributor Author

Looks good so far, but we should wrap two other things into this PR:

  1. Migration of params to 4.5
  2. Regeneration of features.inc

Thanks Bob,
done - https://carbonix.atlassian.net/wiki/spaces/SOF/pages/2281701483/Migrating+SITL+Parameters

@robertlong13 robertlong13 merged commit 35d6ace into CxPilot-7 Aug 29, 2024
42 checks passed
@robertlong13 robertlong13 deleted the feature/SW-304-ci-squash-of-all-carbonix-hwdefs_V2 branch August 29, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlong13 robertlong13 robertlong13 approved these changes

@loki077 loki077 Awaiting requested review from loki077

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pradeep-Carbonix @robertlong13